I will create a new thread for dropping the suffix On Wed, May 13, 2015 at 9:20 AM, Nikhil Khandelwal <nikhi...@microsoft.com> wrote:
> +1 for dropping the suffix - if there is no real good reason for it. I > will make the change to WP8 as it's blocking WP8 CI testing. > > Thanks, > Nikhil > > > -----Original Message----- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Tuesday, May 12, 2015 5:15 PM > To: dev@cordova.apache.org > Subject: Re: [CI] WP8 mobilespec failing to get created (CB-9021) > > > On the flip side, if we do not update cordova-js with the latest on > > its > master, > we would have found this bug CB-8996 much later > > Yeah, true. > > Ultimately I would like to see the entire matrix of possibilities. > > cordova-wp8@npm-published-version + cordova-js@master cordova-wp8@master > cordova-wp8@master + cordova-js@master ... multiply by all platforms Some > things we would expect to fail, others not. > I also would prefer we run individual plugin tests, but that gets messy > real fast. > > > Should the code for cordova-lib be updated to strip out '-dev' suffix? > Yes. I never liked having a version suffix, I never understood why we > needed it. I would prefer we discuss removing it entirely instead of > working around it. Am I missing something? > > > > > > > @purplecabbage > risingj.com > > On Tue, May 12, 2015 at 4:44 PM, Nikhil Khandelwal <nikhi...@microsoft.com > > > wrote: > > > On the flip side, if we do not update cordova-js with the latest on > > its master, we would have found this bug > > https://issues.apache.org/jira/browse/CB-8996 much later - only when > > the cordova.js would have merged to the platform repo - which I > > believe happens only around the time of a release? > > > > Here's the real failure: > > Failed to install 'cordova-plugin-file-transfer':CordovaError: Plugin > > doesn't support this project's cordova-wp8 version. cordova-wp8: > > 4.0.0-dev, failed version requirement: >=4.0.0 > > > > Looks like cordova-lib's version comparison using semver, which does > > not recognize 'dev' in the version of WP8 and fails: > > > > if ( semver.satisfies(engine.currentVersion, > > engine.minVersion) || engine.currentVersion === null ) { > > // engine ok! > > } else { > > var msg = 'Plugin doesn\'t support this project\'s ' + > > engine.name + ' version. ' + > > engine.name + ': ' + engine.currentVersion + > > ', failed version requirement: ' + > engine.minVersion; > > return Q.reject(new CordovaError(msg)); > > } > > > > Should the code for cordova-lib be updated to strip out '-dev' suffix? > > > > -Nikhil > > > > -----Original Message----- > > From: Jesse [mailto:purplecabb...@gmail.com] > > Sent: Tuesday, May 12, 2015 4:30 PM > > To: dev@cordova.apache.org > > Subject: Re: [CI] WP8 mobilespec failing to get created (CB-9021) > > > > I am not entirely sure what the best approach is, personally I would > > just expect it to build with the cordova.js installed by the version. > > There is no guarantee that platforms and cordova-js are in sync at any > > given time. Maybe we should put this behind a flag and have the CI > > run it both with and without ... not sure. > > > > > > > > @purplecabbage > > risingj.com > > > > On Tue, May 12, 2015 at 3:56 PM, Dmitry Blotsky > > <dblot...@microsoft.com> > > wrote: > > > > > Mobilespec builds it by design, I think, to use the latest version > > > of cordova.js. Is that undesired behaviour? We're always using the > > > master version of cordova-wp8 in periodic CI builds. > > > > > > Kindly, > > > Dmitry > > > > > > > On May 12, 2015, at 3:22 PM, Jesse <purplecabb...@gmail.com> wrote: > > > > > > > > What version of cordova-wp8 are you testing? > > > > The failure seems like is doing what it should ... > > > > cordova-wp8@<4.0.0 should not be able to install > > > > cordova-plugin-file-transfer@4.0.0 > > > > > > > > Also, why is createmobilespec always building cordova-js? I would > > > > expect this to sporadically break. > > > > > > > > @purplecabbage > > > > risingj.com > > > > > > > > On Tue, May 12, 2015 at 2:58 PM, Dmitry Blotsky > > > > <dblot...@microsoft.com> > > > > wrote: > > > > > > > >> Hi all, > > > >> > > > >> Mobilespec is failing to get created on WP8 because there is an > > > >> issue > > > with > > > >> dependencies in package.json. I've created a JIRA: > > > >> https://issues.apache.org/jira/browse/CB-9021. > > > >> > > > >> Kindly, > > > >> Dmitry > > > >> > > > > > > > > > -------------------------------------------------------------------- > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > >
