Bottom line, we support way too many things. I'll leave the use of ~ discussion to the other thread, and just say we should drop support for --usegit If you want to install a platform via git, you should clone it yourself, or you should simply use the github.url plus any specific branch/tag logic like what is already supported by plugman [1]
[1] http://cordova.apache.org/docs/en/5.0.0/guide_cli_index.md.html#The%20Command-Line%20Interface ex. cordova plugin add https://github.com/someone/aplugin.git#r0.0.1:/my/sub/dir @purplecabbage risingj.com On Mon, Jun 1, 2015 at 2:29 PM, Steven Gill <stevengil...@gmail.com> wrote: > great catch. We should definitely stop the release due to this. Breaking > change. > > On Mon, Jun 1, 2015 at 2:27 PM, Tim Barham <tim.bar...@microsoft.com> > wrote: > > > I've discovered an issue with the tilde version change we did for pinned > > platforms, but I'm not sure whether or not it should block the release: > > > > If you use the 'usegit' flag when adding a platform ('cordova platform > add > > <platform> --usegit'), it will fail: > > > > $ cordova platform add android --usegit --verbose > > No version supplied. Retrieving version from config.xml... > > Requesting {"url":" > > > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=~3.7.2;sf=tgz > > ","strictSSL":true}... > > Downloading cordova library for android... > > CordovaError: Unable to fetch platform android: Error: HTTP error 400 > > retrieving version ~3.7.2 of cordova for android > > > > I have a possible approach for a fix for this (query npm for the list of > > versions for the target platform, find the latest version that satisfies > > the specified range, and use that). Is this workflow still used by > Cordova > > users? Do we want to block the release until it is fixed? > > > > Thanks, > > > > Tim > > > > -----Original Message----- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Friday, May 29, 2015 2:13 PM > > To: dev@cordova.apache.org > > Subject: Re: [DISCUSS] Tools Release > > > > We could easily do another tools release starting next week once the > > windows 4.0 vote ends. > > > > On Fri, May 29, 2015 at 2:11 PM, Nikhil Khandelwal < > nikhi...@microsoft.com > > > > > wrote: > > > > > I am late to this discussion, but I just started a Windows 4.0.0 > > > platform release and would like to do a tools release after that to > > > pin this Windows release. I'm not sure if there is a guideline around > > > this - and wonder if it makes sense to combine the two TOOLS releases. > > > > > > Thanks, > > > Nikhil > > > > > > > > > -----Original Message----- > > > From: Tim Barham [mailto:tim.bar...@microsoft.com] > > > Sent: Tuesday, May 26, 2015 4:37 PM > > > To: dev@cordova.apache.org > > > Subject: RE: [DISCUSS] Tools Release > > > > > > Great, thanks! > > > > > > -----Original Message----- > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > Sent: Tuesday, May 26, 2015 4:27 PM > > > To: dev@cordova.apache.org > > > Subject: Re: [DISCUSS] Tools Release > > > > > > Tim, did both of them just now. Thanks for the heads up. Issue for > > > pinned dependencies https://issues.apache.org/jira/browse/CB-9075 > > > > > > On Tue, May 26, 2015 at 4:07 PM, Tim Barham <tim.bar...@microsoft.com> > > > wrote: > > > > > > > Couple of things... > > > > > > > > * The pinned version for 'windows' platform needs to be updated to > > > > 3.8.2 ('windows8' got updated, but not 'windows'). > > > > * It would perhaps be good to make the change to allow platform > > > > patch updates (using tilde versions) with this release. I was > > > > planning on doing that today (but got caught up in other things). > > > > > > > > I can make both these changes tonight if you like (I'll spend a > > > > little time verifying the tilde versions work as expected). > > > > > > > > Thanks, > > > > > > > > Tim > > > > > > > > -----Original Message----- > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > > Sent: Tuesday, May 26, 2015 3:38 PM > > > > To: dev@cordova.apache.org > > > > Subject: [DISCUSS] Tools Release > > > > > > > > Does anyone have any reason to delay a tools release? > > > > Any outstanding patches to land? > > > > > > > > If not, I will start the release tomorrow. > > > > > > > > Some pinned platform versions have been updated. > > > > > > > > The versions and changes to be released are: > > > > # lib@5.1.0 > > > > > > > > * CB-9051 Plugins don't get re-added if platforms folder deleted. > > > > * CB-9025 Call windows `prepare` logic on as part of cordova-lib > > > > `prepare`. This closes #217 > > > > * CB-9048 Clean up git cloned directories (close #222) > > > > * CB-8965 copy platform specific js into platform_www when adding > > > > new platforms for browserify workflow > > > > * CB-8965 passing platform as argument when getting symbolList > > > > * CB-8965 copy platform specific js into platform_www when adding > > > > new platforms for browserify workflow > > > > * Add support to specify a build config file. If none is specified > > > > `build.json` in the project root is used as a default This closes > > > > #215 > > > > * CB-9030: Modifies superspawn to support a "chmod" option. When > > > > truthy, attempts to set the target file mode to 755 before executing. > > > > Specifies this argument as truthy for common CLI operations > > > > (compile, run, and steps in plugman). Didn't add it for hooks > > > > runner since that particular mode is in legacy support. > > > > * CB-8997 updated pinned platform versions > > > > * CB-8989 - cordova-lib jasmine tests are failing on older hardware > > > > * CB-6462 CB-6026 - Orientation preference now updates > > > > `UISupportedInterfaceOrientations~ipad` too. > > > > * CB-8898 Introduces `requirements` cordova module > > > > * Update elementtree dependency to 0.1.6. Note it has a breaking API > > > > change. https://github.com/racker/node-elementtree/issues/24 (closes > > > > #209) > > > > * CB-8757 Resolve symlinks in order to avoid relative path issues > > > > (close > > > > #212) > > > > * CB-8956 Remove hardcoded reference to registry.npmjs.org > > > > * CB-8934 fixed regression with projects config.json not being used > > > > in cordova create > > > > * Fix NPE in PluginInfo.getKeywordsAndPlatforms when no keywords > > > > exist > > > > * Fix typo: superspwan --> superspawn > > > > * CB-8908 Make fetching via git faster via --depth=1 > > > > * CB-8897 Make default icon/splash on Android map to mdpi > > > > > > > > # cli@5.1.0 * CB-8898 Introduces `cordova requirements` command # > > > > plugman@0.23.2 * update cordova-lib # cordova-js@4.0.0 * CB-9057: > > > > Updated cordova.js for Windows to refer to base.js instead of the > > > > full-blown WinJS.js. * CB-6865 added support for plugins with any id > > > > * > > > > CB-8802 fixed incorrect variable declaration * CB-8441 added missing > > > > requires and updated npm run scripts * CB-8441 platformVersion flag > > > > not required anymore. Grab version from dependecy platform versions > > > > * > > > > CB-8441 updated workflow to use cordova-js-src when available * > > > > CB-8441 grunt compile now uses platform dependencies cordova-js-src > > > > for platform specific exec files * CB-8441 added platforms as dev > > > > dependencies * Added template-packaged WinJS reference for Windows > > > > 10 support. This closes #111 * CB-8996 (Windows) Fixed invalid null > > > > comparison. This closes #110. * updated browserify dependency to > > > > 10.1.3 * Revert "CB-8674: Creates a 'cordova.env' object, and then > > > > on Windows hangs the" * Revert "reverted global change to cordova > > > > object, added temp? 'activate' event to windows platform" * reverted > > > > global change to cordova object, added temp? 'activate' event to > > > > windows platform > > > > * CB-8674: Creates a 'cordova.env' object, and then on Windows hangs > > > > the activation arguments off of cordova.env.args. * simplified > > > > cordova check, and it still works with ripple * check the > > > > window.cordova object a little more strictly * android: Delete > > > > PRIVATE_API bridge mode enum, since it was removed in 4.0.0 * > > > > CB-8838 - Disabled > > > commandQueue for WK_WEBVIEW_BINDING. > > > > (closes #107) > > > > > > > > -------------------------------------------------------------------- > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
