Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33480844
--- Diff: src/windows/MediaProxy.js ---
@@ -26,6 +26,15 @@ var MediaError =
require('cordova-plugin-media.MediaError');
var recordedFile;
+function setTemporaryFsByDefault(src) {
+ if (!/.+:/.test(src)) {
--- End diff --
This test seems like it could collide with absolute file paths (e.g.,
"c:\foo.bar") or UNC paths (e.g., "\\?\C:\foo.bar"). Are you sure this is
adequate? I'm curious about whether creating a new Windows.Foundation.Uri
would be more likely to detect such sources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
