Github user Gillardo commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34288013
--- Diff: src/windows/CameraProxy.js ---
@@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
if (sensor !== null) {
sensor.addEventListener("orientationchanged",
onOrientationChange);
}
- capturePreview.addEventListener('click', captureAction);
+ //capturePreview.addEventListener('click', captureAction);
--- End diff --
Am I suppose to edit my file with these changes? Never had a "nit" before
On 9 Jul 2015 7:31 pm, "Murat Sutunc" <notificati...@github.com> wrote:
> In src/windows/CameraProxy.js
>
<https://github.com/apache/cordova-plugin-camera/pull/106#discussion_r34287483>
> :
>
> > @@ -370,10 +395,11 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
> > if (sensor !== null) {
> > sensor.addEventListener("orientationchanged",
onOrientationChange);
> > }
> > - capturePreview.addEventListener('click', captureAction);
> > + //capturePreview.addEventListener('click', captureAction);
>
> nit: remove comment if not necessary
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/106/files#r34287483>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
