Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-windows/pull/98#issuecomment-120820494
  
    Looks good to me.
    
    Have you verified no changes need to be made to 
`cordova-lib/src/util/windows/jsprojManager.js` (adding/removing plugins that 
use `<lib-file>` or `<framework>` elements for the windows platform)? Also, you 
might want to update `cordova-lib/spec-plugman/projects/windows/CordovaApp.sln` 
to reflect this change.
    
    Assuming that's all good, is this ready to be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to