Github user robpaveza commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-geolocation/pull/45#discussion_r34479900
  
    --- Diff: src/windows/GeolocationProxy.js ---
    @@ -142,8 +143,8 @@ module.exports = {
                     Windows.Devices.Geolocation.PositionAccuracy.high :
                     Windows.Devices.Geolocation.PositionAccuracy.default;
     
    -        if (cordova.platformId == 'windows' && WinJS.Utilities.isPhone) {
    -            // on Windows Phone 8.1 'positionchanged' event fails with 
error below if movementThreshold is not set
    +        if (cordova.platformId == 'windows' && (WinJS.Utilities.isPhone || 
isWin10)) {
    +            // on Windows Phone 8.1 and Windows 10 'positionchanged' event 
fails with error below if movementThreshold is not set
    --- End diff --
    
    We should just always set the movementThreshold property.  It exists for 
Windows 8 according to the documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to