Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/269#discussion_r35641611
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -236,7 +236,7 @@ function findLocalPlugin(plugin_src, searchpath, 
pluginInfoProvider) {
     
         versions.forEach(function(pinfo) {
             // Ignore versions that don't satisfy the the requested version 
range.
    -        if (!semver.satisfies(pinfo.version, versionspec)) {
    +        if (!semver.satisfies(pinfo.version.replace(/-dev$/, ''), 
versionspec)) {
    --- End diff --
    
    This is not obvious, why this change is required. Could you please add a 
link to JIRA/semver docs or short explanation, why this needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to