Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/124#discussion_r36251972
--- Diff: tasks/lib/packager-browserify.js ---
@@ -46,25 +37,13 @@ module.exports = function generate(platform,
useWindowsLineEndings, platformVers
outReleaseFile = path.join('pkg', 'cordova.' + platform + '.js');
outReleaseFileStream = fs.createWriteStream(outReleaseFile);
- var symbolList = null;
- var addSymbolList = through.obj(function(row, enc, next) {
- if(symbolList === null) {
- symbolList = requireTr.getModules(platform);
- this.push(util.format('var symbolList = %s;\n%s\n',
JSON.stringify(symbolList, null, 4), row));
- } else {
- this.push(row);
- }
- next();
- });
-
- libraryRelease.pipeline.get('wrap').push(addSymbolList);
-
// write license header
writeLicenseHeader(outReleaseFileStream, platform, commitId,
platformVersion);
- releaseBundle = libraryRelease.bundle();
-
- releaseBundle.pipe(outReleaseFileStream);
+ bundle(platform, false, commitId, platformVersion, platformPath)
+ .add(path.resolve(__dirname, '..', '..',
'src/scripts/bootstrap.js'))
--- End diff --
Yes, they both needed. This was moved from `bundle-browserify.js` direcly
to `cordova-lib/prepare-browserify` due to some reasons (see
https://github.com/apache/cordova-lib/pull/275#issuecomment-127782310) but we
still need to add this file when building clean cordova-js bundle (without
plugins) from grunt task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
