Not sure if I agree about rolling this into the Notification plugin: https://github.com/apache/cordova-plugin-dialogs which is materially different in that the dialogs it shows are more intrusive (modal) and have buttons etc and conform more to JavaScript alert, prompt and confirm.
This should be a different plugin. On Sat, Aug 8, 2015 at 5:45 AM, Darryl Pogue <dar...@dpogue.ca> wrote: > My problem with the W3C spec is that there is no mechanism for scheduling > notifications. You tell it to show a notification, and that notification > appears on the screen. The API as spec'ed is already supported in > Chrome/Chromium (on Android and desktop), Safari (on desktop), and Firefox > (desktop, possibly Android?). > > The local-notification plugin doesn't quite match the W3C spec naming, but > it's close enough that it would be minimal work to make it align. That > still leaves the big question of whether to align with the spec (and > browser implementations) which are largely useless, or to add a > non-standard feature to allow scheduling into the future. > Along with that comes scheduling repeating notifications, and canceling > future notifications, and all sorts of fun problems when you can easily > send your phone into an infinite loop of notifications triggering. > > When I've talked to anyone about the gap in the W3C spec, the answer has > always been either ServiceWorkers or the Push API :( > > On 7 August 2015 at 14:37, Joe Bowser <bows...@gmail.com> wrote: > > > I think we can as long as we include where it came from in the NOTICE > file > > and if the licence is compatible. Since this is Apache 2.0, we should be > > fine, but it would be better if the people who wrote the plugin were to > > contribute it. > > > > That said, Local Notifications are trivial to write (at least for > Android), > > and we should just add it into our plugin, since this would be much > > easier. Of course, given our current backlog of issues, I don't think > I'll > > get around to this any time soon, so patches and pull requests are > welcome. > > > > On Fri, Aug 7, 2015 at 1:33 PM Carlos Santana <csantan...@gmail.com> > > wrote: > > > > > I don't think we can accept code into Apache Cordova repos if there is > no > > > ICLA for the originator/owner of the code. > > > You can work with originator of the code to see if he wants to "donate" > > and > > > go thru contribution process to get his code into Apache Cordova. > > > > > > From our website: > > > > > > In order for your changes to be accepted, you need to sign and submit > an > > > Apache ICLA <http://www.apache.org/licenses/#clas> (Individual > > Contributor > > > License Agreement). Then your name will appear on the list of CLAs > signed > > > by non-committers > > > <https://people.apache.org/committer-index.html#unlistedclas> or > Cordova > > > committers < > http://people.apache.org/committers-by-project.html#cordova > > >. > > > > > > And don't forget to test and document your code. > > > > > > > > > > > > > > > On Fri, Aug 7, 2015 at 8:41 AM Paul Contat <contat.p...@gmail.com> > > wrote: > > > > > > > Hi everyone, > > > > I have seen that the description of dialog plugin is "Cordova > > > Notification > > > > Plugin" so I would like to know if adding web notification[1] into > > dialog > > > > plugin is a good idea? > > > > > > > > If yes, is it acceptable to create a wrapper with the correct > > > > implementation around an existing third party plugin[2] or rather > > create > > > > the native side from scratch? > > > > Here is the associate Jira issue : > > > > https://issues.apache.org/jira/browse/CB-6071 > > > > > > > > [1] http://www.w3.org/TR/notifications/ > > > > [2] https://github.com/katzer/cordova-plugin-local-notifications/ > > > > > > > > Thanks, > > > > Paul Contat > > > > > > > > > >
