GitHub user RomainFallet opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/56

    set cancelable to false by default on Android

    To match with the iOS behavior where all modals cannot be canceled by a 
click outside of it (or a back button).
    First of all, there is few case where it is interesting for the developper 
to let the user dismiss the modal by a simple click outside of the modal. And 
it's absolutely not user friendly, the user does not attempt to see the modal 
closing after this action. He can cancel it unintentionally.
    
    Maybe a setting would be a great solution too ?
    
    Here some testimonies of developers that have trouble with this (not only 
with cordova) :
    https://github.com/jquery/jquery-mobile/issues/4727
    
http://stackoverflow.com/questions/23300122/prevent-phonegap-notification-navigator-popups-from-closing-from-touch-outside-o
    http://programming.nullanswer.com/question/27626010
    
http://iswwwup.com/t/5fcbb227c8f7/javascript-prevent-kendo-tooltip-hide-close-when-clicking-outside-the-tooltip.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RomainFallet/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
    
----
commit b6c48989a18e3f0a27c04a68982ceb819834a715
Author: Romain Fallet <romain.fal...@outlook.com>
Date:   2015-08-12T09:52:08Z

    set cancelable to false by default on Android
    
    To match with the iOS behavior where all modals cannot be canceled by a 
click outside of it (or a back button).
    First of all, there is no case where it is interesting for the developper 
to let the user dismiss the modal by a simple click outside of the modal. And 
it's absolutely not user friendly, the user does not attempt to see the modal 
closing after this action.
    
    Here some testimonies of developers that have trouble with this (not only 
with cordova) :
    https://github.com/jquery/jquery-mobile/issues/4727
    
http://stackoverflow.com/questions/23300122/prevent-phonegap-notification-navigator-popups-from-closing-from-touch-outside-o
    http://programming.nullanswer.com/question/27626010
    
http://iswwwup.com/t/5fcbb227c8f7/javascript-prevent-kendo-tooltip-hide-close-when-clicking-outside-the-tooltip.html

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to