Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/114#discussion_r37140530
--- Diff: template/cordova/lib/log.js ---
@@ -114,32 +132,47 @@ function parseEvents(output) {
var results = [];
events.forEach(function (event) {
- // Get only unhandled exceptions from Admin log
- if (getElementValue(event, './System/Channel') ===
'Microsoft-Windows-AppHost/Admin' &&
- typeof getElementValue(event,
'./UserData/WWAUnhandledApplicationException') === 'undefined') {
+ // Get only informative logs
+ if ((getElementValue(event, './System/Channel') ===
'Microsoft-Windows-AppHost/Admin') &&
+ (typeof getElementValue(event,
'./UserData/WWAUnhandledApplicationException') === 'undefined') &&
+ (typeof getElementValue(event,
'./UserData/WWATerminateApplication') === 'undefined')) {
+ return;
+ }
+ if ((getElementValue(event, './System/Channel') ===
'Microsoft-Windows-AppHost/ApplicationTracing') &&
+ (typeof getElementValue(event, './UserData/WWADevToolBarLog')
=== 'undefined')) {
return;
}
var result = {
- channel: getElementValue(event, './System/Channel'),
- timeCreated: getElementValue(event, './System/TimeCreated',
'SystemTime'),
- pid: getElementValue(event, './System/Execution', 'ProcessID'),
- proc: getElementValue(event,
'./UserData/WWADevToolBarLog/DisplayName'),
- source: getElementValue(event,
'./UserData/WWADevToolBarLog/Source'),
- documentFile: getElementValue(event,
'./UserData/WWADevToolBarLog/DocumentFile') ||
- getElementValue(event,
'./UserData/WWAUnhandledApplicationException/DocumentFile'),
- line: getElementValue(event,
'./UserData/WWADevToolBarLog/Line'),
- column: getElementValue(event,
'./UserData/WWADevToolBarLog/Column'),
- sourceFile: getElementValue(event,
'./UserData/WWAUnhandledApplicationException/SourceFile'),
- sourceLine: getElementValue(event,
'./UserData/WWAUnhandledApplicationException/SourceLine'),
- sourceColumn: getElementValue(event,
'./UserData/WWAUnhandledApplicationException/SourceColumn'),
- message: getElementValue(event,
'./UserData/WWADevToolBarLog/Message'),
- displayName: getElementValue(event,
'./UserData/WWAUnhandledApplicationException/DisplayName'),
- appName: getElementValue(event,
'./UserData/WWAUnhandledApplicationException/ApplicationName'),
- errorType: getElementValue(event,
'./UserData/WWAUnhandledApplicationException/ErrorType'),
- errorDescription: getElementValue(event,
'./UserData/WWAUnhandledApplicationException/ErrorDescription'),
- stackTrace: getElementValue(event,
'./UserData/WWAUnhandledApplicationException/StackTrace'),
+ channel: getElementValue(event, './System/Channel'),
+ timeCreated: getElementValue(event,
'./System/TimeCreated', 'SystemTime'),
+ pid: getElementValue(event, './System/Execution',
'ProcessID'),
+ proc: getElementValue(event,
'./UserData/WWADevToolBarLog/DisplayName'),
--- End diff --
Nit: instead of proc & 'Process' - we should call it 'App Name'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
