I think it should be fine since it was like that before April 2014 and was only introduced for crosswalk initial work
- Carlos Sent from my iPhone > On Aug 19, 2015, at 6:39 PM, tommy-carlos williams <[email protected]> wrote: > > So can someone look at merging this in then? > > :) > > Or am I OK to merge my own PR if everyone (well, Joe and Carlos) are happy > with it? > > > On 18 August 2015 at 12:04:55, tommy-carlos williams ([email protected]) > wrote: > > I think they just should have been in the plugin all along… > > If it’s not needed by most apps, it’s kinda annoying to have to remove them > manually :) > > > On 18 August 2015 at 11:59:25, Joe Bowser ([email protected]) wrote: > > That makes sense if the Network Information API is present in Crosswalk. > I'm really wondering how this will work with Marshmallow. > > > > On Mon, Aug 17, 2015 at 6:57 PM tommy-carlos williams <[email protected]> > wrote: > >> I noticed that my app had gained two new permissions on Android and hunted >> them down to an addition for Crosswalk[1] that really should be in the >> Crosswalk plugin itself. >> >> I added the permissions to the Crosswalk plugin, now I want to remove them >> from cordova-android’s templates[3][4] >> >> I just want to make sure there would be no reason to keep these in. >> >> >> 1. >> https://github.com/apache/cordova-android/commit/4a67dd2e28aed257c85b75c11026ae7a2a19c2ad >> 2. >> https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview/pull/43 >> 3. https://issues.apache.org/jira/browse/CB-9496 >> 4. https://github.com/apache/cordova-android/pull/206 >> >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
