Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/118#issuecomment-136498895
I think the logic needs some rework.
Imagine original picture with size 2w x 1h (aspect ratio 2). If we want to
scale this image to 10x5 this CR will provide us with 5x2.5 which is not the
most optimum outcome.
Ideally the outcome should be:
original width x height | aspect ratio
--- | ---
2x1 | 2
target width x height | target aspect ratio | output width x height |
output aspect ratio
--- | --- | --- | ---
10x5 | 2 | 10x5 | 2
12x5 | 2,4 | 10x5 | 2
8x5 | 1,6 | 8x4 | 2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
