Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/220#discussion_r40475167
  
    --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
    @@ -359,4 +361,38 @@ public boolean 
onReceivedClientCertRequest(CordovaWebView view, ICordovaClientCe
          */
         public void onConfigurationChanged(Configuration newConfig) {
         }
    +
    +    /**
    +     * Called by the Plugin Manager when we need to actually request 
permissions
    +     *
    +     * @return              Returns the permission that was stored in the 
plugin
    +     */
    +
    +    public String[] getPermissionRequest() {
    +        return permissions;
    +    }
    +
    +    public boolean hasPermisssion() {
    +        for(String p : permissions)
    +        {
    +            if(PackageManager.PERMISSION_DENIED == 
cordova.getActivity().checkSelfPermission(p))
    --- End diff --
    
    That's probably the case.  I'm almost tempted to remove the code from this 
method entirely, since this really exists only for a Geolocation plugin.  The 
geolocation plugin is a special case, and no other plugins work this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to