I did a quick on review with my limited on android native skills :-) 1. I think the file plugin is missing the engine tag, I saw the other's had the plugin.xml with the engine tag added 2. Don't understand why cordova-android is concern with geolocation permissions, it's like the web view checks and delegate geolocation permissions to the geolocation plugin? Other than that looks, once merged will give it a test run
On Mon, Oct 5, 2015 at 1:32 PM Joe Bowser <[email protected]> wrote: > I was screwing up the scope, sorry. > > We should be initializing it with the permissions in the constructor. The > purpose of it is for the Java API. So, if we have a plugin dependency that > needs to access the permissions of the parent plugin somehow, they can just > request the permissions instead of cueing every permission individually. > > On Mon, Oct 5, 2015 at 10:26 AM, Nikhil Khandelwal <[email protected] > > > wrote: > > > Sorry for not responding earlier. I like where this is going. I have a > > bunch of comments on the PRs. > > > > I have some confusion around how CordovaPlugin has a protected field > > 'permissions' and what a derived CordovaPlugin is supposed to do with it. > > None of our core plugins seem to use it. > > > > Thanks, > > Nikhil > > > > -----Original Message----- > > From: Joe Bowser [mailto:[email protected]] > > Sent: Monday, October 5, 2015 9:05 AM > > To: dev <[email protected]> > > Subject: Merging latest pull requests into Master today > > > > Hey > > > > I'm going to pull the 5.0.x proposed pull requests into Master today. > Can > > anyone take a look at them before I do this. I'm going to wait until > after > > 1 PM to do it, so if you can check out the new pull requests and comment > > on them before then, that would be greatly appreciated, otherwise I'm > going > > to assume all is good and merge them into the master. > > > > You've been warned. ;) > > > > Joe > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > >
