Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159016399
Looks good, except for the java implementation (re)used error code 5
instead of the 6 used everywhere else. The added tests should reveal this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
