Please review the blog post for the plugins release https://github.com/apache/cordova-docs/pull/431
On Fri, Nov 20, 2015 at 12:43 PM, Steven Gill <stevengil...@gmail.com> wrote: > Manually update until we released tools with android 5 pinned. > > The failure is expected. Users will have to manually update to android 5 > or use an older version of file. > > This was discussed before. > > Steps: > * android 5 release > * plugins release > * tools release > On Nov 20, 2015 8:26 AM, "Alexander Sorokin (Akvelon)" < > v-als...@microsoft.com> wrote: > >> Hi guys, >> >> Currently we have Android ~4.1.0 pinned in CLI but the file plugin (and >> all plugins that depend on file plugin) depends on Android@5.0.0 or >> higher, so after this release, this will fail: >> >> cordova platform add android >> cordova plugin add cordova-plugin-file >> >> The output would be: >> Installing "cordova-plugin-file" for android >> Plugin doesn't support this project's cordova-android version. >> cordova-android: 4.1.1, failed version requirement: >=5.0.0-dev >> Skipping 'cordova-plugin-file' for android >> >> So, should Android@5.0.0 be pinned first or are we expecting users to >> manually update android to 5.0.0 ? >> >> Thanks, >> Alexander Sorokin >> >> -----Original Message----- >> From: Steven Gill [mailto:stevengil...@gmail.com] >> Sent: Friday, November 20, 2015 2:04 AM >> To: dev@cordova.apache.org >> Subject: Re: [DISCUSS] Plugins release >> >> Thanks Joe! >> >> P.S. The "r" prefixed tags messed up my coho commands to create the tgz >> and print the corresponding tags. I have now fixed that problem by not >> stripping the "r" for plugin tags so those tags fail the semver check. >> >> Attempt 2 for plugins vote is now out. >> >> >> On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser <bows...@gmail.com> wrote: >> >> > I just did the test again on this end, and the only test failures I >> > got were the ones where I was expected to approve permissions. It >> > seems that these tests will keep running and that the permission >> > dialog won't block the UI. This is the correct behaviour, but it does >> > mean that we have to make sure that we give the permissions for the >> > tests to work before we run them. >> > >> > After I approved all the permissions, I just get three Contacts >> > failures and a Media plugin failure. One of the Contacts failures >> > comes from running on a device that I use day-to-day, since I don't >> > get that one on the HTC One M8, but the other three errors are >> consistent. >> > >> > Furthermore, the manual tests for Media work fine, so I don't think >> > that this should block the release. >> > >> > On Wed, Nov 18, 2015 at 11:24 PM, Steven Gill <stevengil...@gmail.com> >> > wrote: >> > >> > > Oh and 1 failing cordova-plugin-file-transfer test. >> > > >> > > I'll look more into the failures tomorrow. >> > > >> > > >> > > On Wed, Nov 18, 2015 at 11:12 PM, Steven Gill >> > > <stevengil...@gmail.com> >> > > wrote: >> > > >> > > > all the plugins have been updated and are ready to be voted on. >> > > > >> > > > I am getting 10 failing tests on my nexus 5X >> > > > (cordova-android@5.0.0, running marshmallow on phone). >> > > > * contacts (always failing for me) >> > > > * media >> > > > >> > > > Can someone else try running mobile spec and tell me what they are >> > > seeing? >> > > > >> > > > I can start the vote thread once these are resolved or we decide >> > > > they >> > are >> > > > expected. Everything has been tagged but I can easily update tags >> > > > if >> > > needed. >> > > > >> > > > >> > > > >> > > > On Tue, Nov 10, 2015 at 11:50 PM, julio cesar sanchez < >> > > > jcesarmob...@gmail.com> wrote: >> > > > >> > > >> Any more iOS experts can review my pull request? >> > > >> >> > > >> 2015-11-11 6:59 GMT+01:00 Steven Gill <stevengil...@gmail.com>: >> > > >> >> > > >> > Going to move forward with this tomorrow. Any holdups, let me >> know. >> > > >> Here or >> > > >> > #plugins on slack. >> > > >> > >> > > >> > On Fri, Nov 6, 2015 at 2:51 PM, Richard Knoll < >> > rikn...@microsoft.com> >> > > >> > wrote: >> > > >> > >> > > >> > > I plan on merging in >> > > >> > > https://github.com/apache/cordova-plugin-camera/pull/135 for >> > > >> > > the >> > > >> camera >> > > >> > > plugin if there are no objections. >> > > >> > > >> > > >> > > Thanks, >> > > >> > > Richard >> > > >> > > >> > > >> > > -----Original Message----- >> > > >> > > From: Steven Gill [mailto:stevengil...@gmail.com] >> > > >> > > Sent: Friday, November 6, 2015 11:38 AM >> > > >> > > To: dev@cordova.apache.org >> > > >> > > Subject: Re: [DISCUSS] Plugins release >> > > >> > > >> > > >> > > With plugin changes, it is always nice to get reviews since >> > > >> > > it >> > could >> > > >> > > affect every platform. >> > > >> > > >> > > >> > > file:146 is merged >> > > >> > > file: 119 LGTM >> > > >> > > Statusbar: 38 could use a review by iOS experts >> > > >> > > >> > > >> > > Keep em coming in! >> > > >> > > >> > > >> > > -Steve >> > > >> > > >> > > >> > > On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald < >> > > >> > simon.macdon...@gmail.com >> > > >> > > > >> > > >> > > wrote: >> > > >> > > >> > > >> > > > I agree with Jason, >> > > >> > > > >> > > >> >> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu >> > > >> > > > b.com >> > > >> > > >> > %2fapache%2fcordova-plugin-file%2fpull%2f146&data=01%7c01%7cRIKNOLL% >> > > >> > > https://na01.safelinks.protection.outlook.com/?url=40exchange >> > > >> > > .microsoft.com&data=01%7c01%7cv-alsoro%40microsoft.com%7ccad2 >> > > >> > > 2f83ea8d4a87604808d2f135cf14%7c72f988bf86f141af91ab2d7cd011db >> > > >> > > 47%7c1&sdata=R3FyrjOLuuwRQPKnqXux%2bUdhhJ7l4Q85lPfXXDnVIq8%3d >> > > >> > >> > > >> >> > > >> > %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47 >> > %7c1&sdata=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX4Sm%2f3OdrdACiHb8%3d >> > > >> > > should be merged. >> > > >> > > > >> > > >> > > > Simon Mac Donald >> > > >> > > > >> > > >> >> > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im% >> > > >> > > > 2fsimonmacdonald&data=01%7c01%7cRIKNOLL% >> > https://na01.safelinks.protection.outlook.com/?url=40exchange.microsof >> > t.com&data=01%7c01%7cv-alsoro%40microsoft.com%7ccad22f83ea8d4a87604808 >> > d2f135cf14%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=R3FyrjOLuuwRQP >> > KnqXux%2bUdhhJ7l4Q85lPfXXDnVIq8%3d >> > > >> %7c1e6 >> > > >> > > > >> > > >> 52e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47% >> > > >> 7c1&s >> > > >> > > > data=MXNVR%2bXGeH703bFkFHohHk6EwL8amOj4btn2kNuUPiU%3d >> > > >> > > > >> > > >> > > > On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau >> > > >> > > > <jason...@microsoft.com> >> > > >> > > > wrote: >> > > >> > > > > I think this PR should get in the release: >> > > >> > > > >> > > >> >> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu >> > > >> > > > b.com >> > > >> %2fapache%2fcordova-plugin-file%2fpull%2f146&data=01%7c01%7cRIKNO >> > > >> > > > LL%40exchange.microsoft.com >> > > >> %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98 >> > > >> > > > >> > > >> 8bf86f141af91ab2d7cd011db47%7c1&sdata=HU0E%2fMPc3C2cD%2fNEtQlLGSt >> > > >> zqfDX >> > > >> > > > 4Sm%2f3OdrdACiHb8%3d >> > > >> > > > > It might be considered a blocker, because it is a >> > > >> > > > > regression >> > > that >> > > >> > > > > could >> > > >> > > > cause loss of data when upgrading apps which relied on the >> > default >> > > >> > > > AndroidPersistentFileLocation value. >> > > >> > > > > >> > > >> > > > > This would be a good one also, as it fixes a significant >> > failure >> > > >> > > > > working >> > > >> > > > with some kinds of files on Android 5.0: >> > > >> > > > >> > > >> >> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu >> > > >> > > > b.com >> > > >> %2fapache%2fcordova-plugin-file%2fpull%2f119&data=01%7c01%7cRIKNO >> > > >> > > > LL%40exchange.microsoft.com >> > > >> %7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98 >> > > >> > > > >> > > >> 8bf86f141af91ab2d7cd011db47%7c1&sdata=TxHgwQq3dyT4Qlo7PM%2fQ0iU3K >> > > >> htoMP >> > > >> > > > J5uU3UqGcY6yA%3d >> > > >> > > > > >> > > >> > > > > Jason >> > > >> > > > > >> > > >> > > > > -----Original Message----- >> > > >> > > > > From: Steven Gill [mailto:stevengil...@gmail.com] >> > > >> > > > > Sent: Thursday, November 5, 2015 3:09 PM >> > > >> > > > > To: dev@cordova.apache.org >> > > >> > > > > Subject: [DISCUSS] Plugins release >> > > >> > > > > >> > > >> > > > > I plan on starting a plugins release on Monday. It is >> > > >> > > > > going to >> > > be >> > > >> a >> > > >> > > > > big >> > > >> > > > one. >> > > >> > > > > >> > > >> > > > > Please review and close as many PRs as you can before than. >> > > >> > > > > >> > > >> > > > > If you have PR that is ready and needs someone to look at >> > > >> > > > > + >> > > merge, >> > > >> > > > please share it in this thread and we will try to get to it >> > before >> > > >> the >> > > >> > > > release. >> > > >> > > > > You could also share it on slack[1] in the #plugins >> channel. >> > > >> > > > > >> > > >> > > > > Let me know if we have any blockers. >> > > >> > > > > >> > > >> > > > > Cheers, >> > > >> > > > > -Steve >> > > >> > > > > >> > > >> > > > > >> > > >> > > > > [1] >> > > >> > > > >> > > >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fs >> > > >> lack >> > . >> > > >> > > > cordova.io&data=01%7c01%7cjasongin%40microsoft.com >> > > >> %7c6bb15854633242978 >> > > >> > > > >> > > >> d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=QY3N >> > > >> j3rIJ >> > > >> > > > VCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d >> > > >> > > > >> > > >> > > > >> > > >> ----------------------------------------------------------------- >> > > >> ---- >> > > >> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> > > >> > > > For additional commands, e-mail: >> > > >> > > > dev-h...@cordova.apache.org >> > > >> > > > >> > > >> > > > >> > > >> > > >> > > >> > > >> > > -------------------------------------------------------------------- >> > > - >> > > >> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> > > >> > > For additional commands, e-mail: dev-h...@cordova.apache.org >> > > >> > > >> > > >> > >> > > >> >> > > > >> > > > >> > > >> > >> >
