Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/87#discussion_r46023669
--- Diff: tests/tests.js ---
@@ -37,23 +37,34 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 30000;
- var removeContact = function() {
- if (gContactObj) {
- gContactObj.remove(function() {}, function() {
- console.log("[CONTACTS ERROR]: removeContact cleanup
method failed to clean up test artifacts.");
- });
- gContactObj = null;
- }
- };
+ var removeContact = function(done) {
+ if (!done) {
+ done = function noop () { };
--- End diff --
I just realized that `removeContact` is now used only in async way (with
`done`) so this is not needed at all. Removing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
