Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-160807204
Apologies for not getting to this last week like I said I would (I didn't
really have much of an Internet connection). I did some more testing on this PR
today and found a few bugs/edge cases that I've now fixed. This PR has been
rebased to master and I pushed a new commit that handles the following:
* PluginResults with multipart messages are now handled properly in the
`resume` payload
* The `resume` event is now fired when the Activity is destroyed even if
there isn't a pending result
* A potential concurrency issue in CoreAndroid has been handled
Please review this new commit. Since I pushed some changes I will wait to
merge this in until end of day tomorrow. Let met know if there are any
objections. For the record, I tested as follows:
* Ran mobilespec auto tests on a 6.0.0 device and a 5.1.1 emulator (minus
the file transfer tests) and confirmed output matched master (one orientation
failure on 5.1.1, but I believe it is the emulator's fault)
* Ran the platform unit tests on a 6.0.0 device and a 5.1.1 emulator and
confirmed output matched master (one failure)
* Did some manual testing with a 6.0.0 device and a 5.1.1 emulator
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
