Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161811902
I agree the file path handling code probably should be centralized in the
platform lib for each platform. But it should be done as part of a broader
effort to make all plugin APIs more consistent in handling files. (My audit
supporting that is still in progress.)
I'm OK with adding this bit of duplicated code for now to fix this bug,
knowing it may be refactored later. Also note ideally the contact photo APIs
should also support cdvfile:// paths, assuming we don't deprecate cdvfile://.
But again I wouldn't block this fix because of that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
