I am not 100% sure, but as I looked at the code, it seems the original intention of pre_package hook is to allow users to make any necessary changes before we do windows-specific changes (for example adding BOM \ufeff in the source codes for windows store certification).
Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation From: Jesse <[email protected]<mailto:[email protected]>> Reply-To: "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Date: Wednesday, December 9, 2015 at 2:06 PM To: "[email protected]<mailto:[email protected]>" <[email protected]<mailto:[email protected]>> Subject: Re: Purpose of pre_package hook for windows I can't find any info on why we needed it ... it seems to be fired right before the files are added to the csproj, though I am not sure why. The only other person I think may know anything about it would be @sgrebnov The earliest JIRA ticket I could find on the issue [1] although the issue is just that it exists in wp7 but not wp8. [1] https://issues.apache.org/jira/browse/CB-5261 @purplecabbage risingj.com On Wed, Dec 9, 2015 at 11:53 AM, Vladimir Kotikov (Akvelon) < [email protected]<mailto:[email protected]>> wrote: Hi, guys. Could anyone please shed some light on the subject? Looking into PR for 'nohooks' option [1] I realized that we have a logic in Windows/wp8 parsers that fires a hooks, specific for these particular platforms. I see 2 problems with this: 1. This doesn't fits well into the concept of PlatformApi 2. The original purpose of the hook is now lost. It was intended to be fired in the middle of prepare [2], to allow to modify www folder before it will be packed into app package, but now it get fired right before the end of platform preparation, and hence almost equal to 'after_prepare'. So the question is, should we still have these hooks in new windows platform? Or we can just move it into LIB and fire just after the prepare and only for windows/wp8? [1] https://github.com/apache/cordova-lib/pull/353 [2] https://github.com/apache/cordova-lib/commit/bd2c667e947b3fda05541e0d1a124d23df60a132 --------------- Best regards, Vladimir --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
