Github user dpogue commented on the pull request:

    https://github.com/apache/cordova-android/pull/247#issuecomment-166521273
  
    I think I'd agree that `def manifest = new 
XmlSlurper().parse(file("AndroidManifest.xml"))` is better. In this case I was 
just trying to copy what already existed for reading the version number.
    
    It looks like the helpers use a slightly different method for parsing the 
config.xml:
    ```gradle
    def doGetConfigXml() {
        def xml = file("res/xml/config.xml").getText()
        // Disable namespace awareness since Cordova doesn't use them properly
        return new XmlParser(false, false).parseText(xml)
    }
    ```
    
    I'm not sure which approach is best. Maybe @infil00p or one of the 
Crosswalk devs has a better idea of gradle best practices? (I'm pretty sure 
none of this is considered "best practices" though)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to