+1 ran coho create-archive --tag 5.1.0 -r android --dest test-android/ compare pacakge and only minor differences in node_modules some extra test folders ran coho verify-archive vote-android51/ ran coho verify-tags -r android --tag 5.1.0 created hello-world app
On Thu, Jan 21, 2016 at 10:08 AM Alexander Sorokin (Akvelon) < v-als...@microsoft.com> wrote: > I vote +1: > > * Verified archives via `coho verify-archive` > * Verified tags manually > * Verified that blank app creates correctly with platform > * Verified that blank app can be successfully ran and built > * Verified that platform can be updated from previous version > * Verified compatibility with core plugins (ran mobilespec for release and > master versions) > * Went through release notes > * Checked for whitespace issues > * Checked for Unicode issues > * Verified version > * Verified line breaks > > Thanks, > Alexander Sorokin > > -----Original Message----- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Thursday, January 21, 2016 4:14 AM > To: dev@cordova.apache.org > Subject: [Vote] 5.1.0 Android Release > > Please review and vote on this 5.1.0 Android Release by replying to this > email (and keep discussion on the DISCUSS thread) > > Release issue: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10391&data=01%7c01%7cv-alsoro%40microsoft.com%7c77fafc81b5a9417fa61e08d322003b39%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=t%2b6cNtTxY19SHV80kP0ACCDEZJCCv%2b3q5HUjh9bT424%3d > > The archive has been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10391 > > The package was published from its corresponding git tag: > cordova-android: 5.1.0 (b8815c24fa) > > Note that you can test it out via: > > cordova platform add https://github.com/apache/cordova-android#5.1.0 > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Built and ran mobile-spec > * Built hello world using CLI > * Upgraded cordova-android@4.1.1 hello world app to 5.1.0 > * Added platform via git and created hello world > * Built a project using platform create script >
