Looks like we don't have auto tests for InAppBrowser plugin at all. We should write sanity test to ensure plugin is successfully initialized at least (there is cordova.InAppBrowser.open method available). I also think that it is doable to write auto tests for main events (load start/stop, etc) as well.
PS. CB-10428 has been resolved by the following PR: https://github.com/apache/cordova-plugin-inappbrowser/pull/141/files?w=1 -Sergey -----Original Message----- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Tuesday, January 26, 2016 12:43 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] inAppBrowser plugin release Looks like there is another regression w.r.t. browserify workflow CB-10428 for Cordova-inappbrowser. And this one for cordova-plugin-file: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10419&data=01%7c01%7cv-segreb%40microsoft.com%7c87655d4803a54891496f08d325d090c1%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=VT5z308fXUhduPr40kC6zA0IsPT4apTeA%2fnStCYkFG8%3d We might to rev those and re-release. -Nikhil -----Original Message----- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Monday, January 25, 2016 10:23 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] inAppBrowser plugin release I'm curious what caused the regression? Why do we not have tests for this important scenario? -Nikhil -----Original Message----- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Monday, January 25, 2016 1:19 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] inAppBrowser plugin release +1 Lets do it! On Mon, Jan 25, 2016 at 1:00 AM, julio cesar sanchez <jcesarmob...@gmail.com > wrote: > On latest release of inAppBrowser plugin the loadstart event stopped > working on android. > It has been fixed on the 1.2.1-dev. > Should we release it? > > I think loadstart is very important and a lot of apps rely on it for > closing the window. > B KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB [ X ܚX KK[XZ[ ] ][ X ܚX P ܙݘK \X K ܙ B ܈Y][ۘ[ [X[ K[XZ[ ] Z[ ܙݘK \X K ܙ B B KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB [ X ܚX KK[XZ[ ] ][ X ܚX P ܙݘK \X K ܙ B ܈Y][ۘ[ [X[ K[XZ[ ] Z[ ܙݘK \X K ܙ B
