Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/368#issuecomment-176912757
LGTM. My only suggestion would be that it might be nice if we grabbed the
deprecation info from somewhere instead of hard coding it in that method. Is it
already encoded somewhere in cordova-lib? If not, should it be? Or should it be
specified in the platform somehow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
