> What is the impact to our workflow? are we just adding a node dependency, or > are there other config/integration parts that we need to do? The only thing, required from our side is to replace `npm test` (or the command, that executes jasmine tests) witn `npm run cover` in Travis configuration (the coverage reports are already enabled for the most important repos). However, some help from infra side is required to setup Github <-> codecov.io integration.
> You are using istanbul for code coverage it seems. Yup. > Why did you remove spec-cordova in your pr? Your [2] Only for demo purposes. I wanted to see how it will look like :) > I think it is a great idea to include this in our repos. It would be nice to > track our coverage and work on improving it. > Though I do believe it is important not to chase 100% code coverage. Agree here, 100 % coverage is not the goal, We can just reach an agreement on a minimal appropriate value and try to not to drop coverage below this bar. - Best regards, Vladimir -----Original Message----- From: Jesse [mailto:[email protected]] Sent: Tuesday, February 2, 2016 2:22 AM To: [email protected] Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos This looks good, as a metric to add. What is the impact to our workflow? are we just adding a node dependency, or are there other config/integration parts that we need to do? @purplecabbage https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=1SLJ4U2YHSQpiukrYipGlq7uBfl4uQNHxSE8q1JspDQ%3d On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill <[email protected]> wrote: > Hey Vlad! > > This looks great! You are using istanbul for code coverage it seems. > > Why did you remove spec-cordova in your pr? Your [2] > > I think it is a great idea to include this in our repos. It would be > nice to track our coverage and work on improving it. > > Though I do believe it is important not to chase 100% code coverage. > > > On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) < > [email protected]> wrote: > > > Hey, guys > > > > I've spent a couple of hours and have a prototype of how we can > visualize, > > track and analyze code coverage for our repos. > > Here is the fork of cordova-lib repo integrated with > > https://na01.safelinks.protection.outlook.com/?url=codecov.io&data=0 > > 1%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d > > 32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0oRS0Omv1Bac3 > > OVYlTyT08ENLSP15s1%2fw%2fvXxcO39ZA%3d [1] (notice the coverage badge > > at the top of README), and a PR with some coverage metrics [2]. The > > coverage summary is placed here [3] > > > > If this proposal get accepted, I'd like to enable this feature for > > all > our > > repos, to encourage contributors to increase current test coverage > > up to appropriate values. > > > > It'd be great if anyone could give any feedback on this > > > > [1] https://github.com/vladimir-kotikov/cordova-lib > > [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2 > > [3] > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcod > > ecov.io%2fgithub%2fvladimir-kotikov%2fcordova-lib&data=01%7c01%7cv-v > > lkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b5e79c2%7c > > 72f988bf86f141af91ab2d7cd011db47%7c1&sdata=mtQlIC3U2lyzKA%2byFchr1zl > > Yp9PuEUsFRH74kUaqLxg%3d > > > > - > > Best regards, Vladimir > > > > -------------------------------------------------------------------- > > - To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
