Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/370#issuecomment-178554295
@dblotsky, @purplecabbage, thanks for feedback. Agree, this probably smells
fishy. However, the only one option i see apart from this one is to setup a
proxy to transmit events from `cordova-common` to another `EventEmitter`
instance (which was passed to `PlatformApi` constructor), when necessary.
All other solutions, that came into my mind, break `events` API and hence
require some global changes in cordova (as the `events` is used really widely).
However, this PR doesn't change a public API for this and seems to fix the
issue with missing events from `cordova-common` internals without affecting any
other cases, so it might make sense to get this in as an intermediate fix and
then start looking into redesigning cordova `events` mechanics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
