Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/70#discussion_r52822803
--- Diff: src/windows/GeolocationProxy.js ---
@@ -181,10 +178,11 @@ module.exports = {
callbacks = ids[clientId];
--- End diff --
Changed the declarations. I am not sure about adding an assertion or
throwing an exception. Consider a scenario in which I press the "Stop watching"
in mobilespec before "Start Watching". This is a valid scenario. I just don't
want an assertion or exception in such a scenario. (as the reason is simply
there is nothing to stop)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
