Oops. My +1 was for removing them in this case. But I don't have a issue with keeping them either. Let's see what Shaz says when he manages to feel better. He has been sick the last few days. On Feb 23, 2016 6:39 PM, "Tobias Bocanegra" <[email protected]> wrote:
> On Tue, Feb 23, 2016 at 4:16 PM, Steven Gill <[email protected]> > wrote: > > +1 > > +1 to what? keep the prefixes or remove them? :-)) > > regards, toby > > > > > On Tue, Feb 23, 2016 at 6:24 AM, julio cesar sanchez < > [email protected] > >> wrote: > > > >> +1 to prefixed versions > >> > >> I always use the same bundle identifier/package name for the same app, > but > >> I sometimes have to use a different version for the android or iOS app, > so > >> it's better if I can set them directly from the config.xml and not use a > >> hook. > >> > >> > >> 2016-02-23 7:54 GMT+01:00 Tobias Bocanegra <[email protected]>: > >> > >> > Hi, > >> > > >> > he current commons code uses ios-CFBundleVersion and > >> > ios-CFBundleIdentifier: [0], [1] > >> > > >> > Now with OSX in the game there could be similar new attributes > >> > osx-CFBundleVersion and osx-CFBundleIdentifier or we could deprecate > >> > the ios-* ones and just use their plain names without prefix. > >> > > >> > suggest: > >> > - use CFBundleVersion and CFBundleIdentifier for iOS and OSX platform. > >> > - deprecate ios-CFBundleVersion and ios-CFBundleIdentifier > >> > > >> > drawback: > >> > using the un-prefixed attribute names would prevent a project of > >> > having different versions/identifiers for the ios and osx platforms. > >> > if one wants to evolve them separately, he would then need to use some > >> > hooks to tweak the config.xml. > >> > > >> > counter argument: > >> > windows and android also use prefixed versions, so maybe its better > >> > to keep this pattern consistent. > >> > > >> > see [2]. > >> > > >> > regards, toby > >> > > >> > [0] > >> > > >> > https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L106 > >> > [1] > >> > > >> > https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L132 > >> > [2] https://issues.apache.org/jira/browse/CB-10603 > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: [email protected] > >> > For additional commands, e-mail: [email protected] > >> > > >> > > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
