Github user omefire commented on a diff in the pull request:

    
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54679929
  
    --- Diff: src/ios/CDVCamera.m ---
    @@ -78,7 +131,10 @@ + (instancetype) 
createFromTakePictureArguments:(CDVInvokedUrlCommand*)command
         pictureOptions.mediaType = [[command argumentAtIndex:6 
withDefault:@(MediaTypePicture)] unsignedIntegerValue];
         pictureOptions.allowsEditing = [[command argumentAtIndex:7 
withDefault:@(NO)] boolValue];
         pictureOptions.correctOrientation = [[command argumentAtIndex:8 
withDefault:@(NO)] boolValue];
    -    pictureOptions.saveToPhotoAlbum = [[command argumentAtIndex:9 
withDefault:@(NO)] boolValue];
    +
    +    BOOL isDestinationNativeUri = (pictureOptions.destinationType == 
DestinationTypeNativeUri);
    +    BOOL isSourceCamera = (pictureOptions.sourceType == 
UIImagePickerControllerSourceTypeCamera);
    +    pictureOptions.saveToPhotoAlbum = [[command argumentAtIndex:9 
withDefault:@(NO)] boolValue] || (isDestinationNativeUri && isSourceCamera);
    --- End diff --
    
    A comment for the reason behind this 'quirk' would be good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to