Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/402#discussion_r55119960
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -71,7 +71,8 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir,
project_dir = cordovaUtil.convertToRealPathSafe(project_dir);
plugins_dir = cordovaUtil.convertToRealPathSafe(plugins_dir);
options = options || {};
- options.is_top_level = true;
+ if (options.is_top_level === undefined)
--- End diff --
I meant that IMO the purpose of this check is to validate id someone
already specified this value, and in this case it's beter to use
`hasOwnProperty` which does exactly what it means
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
