Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/160#discussion_r56205299
  
    --- Diff: template/cordova/lib/prepare.js ---
    @@ -172,6 +172,15 @@ function applyCoreProperties(config, manifest) {
             manifest.getVisualElements().setDisplayName(name);
         }
     
    +    var description = config.description();
    +    manifest.getProperties().setDescription(description);
    +    if (description) {
    --- End diff --
    
    This breaks if say you add a description to config.xml and then remove it - 
the old description will remain in appxmanifest - we might have to revert back 
the old description in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to