Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/282#discussion_r56683077
--- Diff: bin/templates/cordova/Api.js ---
@@ -263,48 +220,15 @@ Api.prototype.addPlugin = function (plugin,
installOptions) {
* CordovaError instance.
*/
Api.prototype.removePlugin = function (plugin, uninstallOptions) {
-
- if (!plugin || plugin.constructor.name !== 'PluginInfo')
- return Q.reject(new CordovaError('The parameter is incorrect. The
first parameter to addPlugin should be a PluginInfo instance'));
-
- var self = this;
- var actions = new ActionStack();
var project = AndroidProject.getProjectFile(this.root);
+ return PluginManager.get(this.platform, this.locations, project)
+ .addPlugin(plugin, uninstallOptions)
--- End diff --
did u mean ```.removePlugin``` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
