Github user riknoll commented on the pull request:

    
https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-197549101
  
    @adamduren  I've tested this and the save/restore stuff appears to work 
great! There is an issue, however, with the results that are returned in the 
resume event. They need to be wrapped in `MediaFile` objects before use. This 
was also an issue in the Contacts plugin where they needed to be wrapped in a 
`Contact` object and the solution was to just provide an example of how to do 
that in the README (see 
[here](https://github.com/apache/cordova-plugin-contacts#android-quirks)). In 
this plugin it is a little bit trickier because we need to decide how to expose 
the `MediaFile` object creation. Currently, it just happens in the `exec` 
callback 
[here](https://github.com/apache/cordova-plugin-media-capture/blob/0867898701c9f547dddd8448bfc0f46d6ae14008/www/capture.js#L34)
 without a public API. Thoughts? Maybe we should add a `MediaFile` constructor 
that encapsulates that `exec` callback? That at least would not be a breaking 
change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to