Github user dubeejw commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57904729
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -441,40 +451,47 @@ describe('windows project handler', function () {
});
});
- describe('of <framework> elements', function () {
+ describe('of <framework> elements', function () {
// This could be separated into individual specs, but that
results in a lot of copying and deleting the
// project files, which is not needed.
it('should remove from correct project files when conditions
specified', function () {
+ var curDir;
+ curDir = __dirname;
+ process.chdir(path.join(curDir, '..', 'fixtures',
'testProj'));
+
var frameworks = copyArray(valid_frameworks);
frameworks.forEach(function(framework) {
PluginHandler.getInstaller('framework')(framework,
dummyPluginInfo, dummyProject);
});
- var path = 'ItemGroup/Reference';
--- End diff --
A variable named differently from "path" has to be used here. This is
because a variable named "path" is already declared at the top of the file. See
line 23: var path = require('path');. In addition, path.join() is used in this
code, so overwriting the "path" variable will cause us to lose our reference to
the path module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
