Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/112#discussion_r58097905
--- Diff: tests/tests.js ---
@@ -589,10 +589,8 @@ exports.defineAutoTests = function() {
removeContactsByFields(["note"], "DeleteMe", function() {
contact.save(function(c_obj) {
var findWin = function(cs) {
- // update to have proper saved id
- contact = cs[0];
expect(cs.length).toBe(1);
- done();
+ done(cs[0]);
--- End diff --
@omefire @riknoll In case of specs 26 &27 - they are bound to different
functions. But for specs 25, 28, 29 - they are bound to actual done functions
(in which case the passed in parameter will just be ignored)
But, the name need not be done. I agree. I changed it to callbacl and
updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
