Github user shazron commented on the pull request:

    
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8#issuecomment-215585938
  
    I also commented on #7. 
    
    To solve this problem, instead of having to instantiate WKWebView twice 
here, I think we can safely move all initializing code from the initWithFrame, 
to pluginInitialize:
    
https://github.com/apache/cordova-plugin-wkwebview-engine/blob/33a75172a1450e8922788cd23382cc6ec33845c7/src/ios/CDVWKWebViewEngine.m#L50-L64
 -- all we need to do is save the CGRect for the frame for later. At this 
point, with this approach, the WKWebView will have been instantiated for this 
return call: 
https://github.com/apache/cordova-ios/blob/e51eda0f3b1e68d210182c3bbd3d9022c1ffe8ec/CordovaLib/Classes/Public/CDVViewController.m#L426
    
    As I mentioned in #7, we still need updateWithInfo.
    
    The rest of your approach is sound.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to