Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215857823
@macdonst
I had Edna test the first time around before I opened the PR and she was
able to get it working, so that is weird that it is adding a new element for
you.
Was config-file functional in config.xml before? Or was that something to
be done as part of this jira issue? I was only focused on getting it working in
plugin.xml, so I can work on it if it isn't implemented yet. Should config.xml
handle config-file during prepare?
The mode suggestion sounds good. It will give users a lot of utility for
modifying xml files.
I have just few clarification questions:
- If no mode is specified, is the default to add?
- For replace, if there is nothing to replace, should it still try to add?
- And for delete, should it delete an element even if the element has
children?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
