Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61789809
--- Diff: cordova-js-src/platform.js ---
@@ -56,9 +57,9 @@ module.exports = {
// OR cordova.require('cordova/platform').activationContext
// activationContext:{type: actType, args: args};
var activationHandler = function (e) {
- var args = e.detail.arguments;
- var actType = e.detail.type;
- platform.activationContext = { type: actType, args: args };
+ // Making all the details available as activationContext
+ platform.activationContext = utils.clone(e.detail);
+ platform.activationContext.args = e.detail.arguments;
/* for backwards compatibility */
--- End diff --
I just mean that we have gone thru the trouble of using utils.clone, which
to me implies that we want a shallow copy, and then we were also passing a deep
copy of arguments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
