Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/434#discussion_r61915826
  
    --- Diff: cordova-common/src/superspawn.js ---
    @@ -22,7 +22,7 @@ var fs = require('fs');
     var path = require('path');
     var _ = require('underscore');
     var Q = require('q');
    -var shell = require('shelljs');
    +var which = require('shelljs/src/which');
    --- End diff --
    
    Also, does this really save any time? Lots of sources require shelljs, so 
I'd expect it to be fully loaded somewhere else anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to