Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/251#discussion_r63492417
--- Diff: src/cli.js ---
@@ -234,17 +234,24 @@ function cli(inputArgs) {
var args = nopt(knownOpts, shortHands, inputArgs);
- if (args.version) {
- var cliVersion = require('../package').version;
+ var cliVersion = require('../package').version;
+ // TODO: Use semver.prerelease when it gets released
+ var usingPrerelease = /-nightly|-dev$/.exec(cliVersion);
+ if (args.version || usingPrerelease) {
var libVersion = require('cordova-lib/package').version;
var toPrint = cliVersion;
if (cliVersion != libVersion || /-dev$/.exec(libVersion)) {
toPrint += ' (cordova-lib@' + libVersion + ')';
}
- console.log(toPrint);
- return Q();
- }
+ if (args.version) {
+ console.log(toPrint);
+ return Q();
+ } else {
+ // Show a warning and continue
+ console.log('Warning: using prerelease version ' + toPrint);
--- End diff --
Logger is being initialized below that's why I'm not using it.
I agree regarding the `warn` visibility though - will try to refactor this,
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
