Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/122#discussion_r63578645
  
    --- Diff: src/nightly.js ---
    @@ -60,36 +62,26 @@ module.exports = function*(argv) {
         }
     
         // Clone and update Repos
    -    yield repoclone.cloneRepos(repos, /*silent=*/true);
    -    yield repoupdate.updateRepos(repos);
    -
    -    //remove local changes and sync up with remote master
    -    yield repoutil.forEachRepo(repos, function*() {
    -        yield gitutil.gitClean();
    -        yield gitutil.resetFromOrigin();
    -    });
    +    yield prepareRepos(argv.r);
    --- End diff --
    
    :nit it's a bit hard to reason about these yields (especially the nested 
ones).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to