Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64677389
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject) {
AppxManifest.purgeCache();
// Update own www dir with project's www assets and plugins' assets
and js-files
- return Q.when(updateWwwFrom(cordovaProject, this.locations))
+ return Q.when(updateWww(cordovaProject, this.locations))
.then(function () {
// update project according to config.xml changes.
return updateProjectAccordingTo(self._config, self.locations);
})
.then(function () {
- copyImages(cordovaProject.projectConfig, self.root);
+ copyImages(cordovaProject, self.locations);
})
.then(function () {
events.emit('verbose', 'Prepared windows project successfully');
});
};
+module.exports.clean = function (options) {
+ // A cordovaProject isn't passed into the clean() function, because it
might have
+ // been called from the platform shell script rather than the CLI.
Check for the
+ // noPrepare option passed in by the non-CLI clean script. If that's
present, or if
+ // there's no config.xml found at the project root, then don't clean
prepared files.
+ var projectRoot = path.resolve(this.root, '../..');
+ var projectConfigFile = path.join(projectRoot, 'config.xml');
--- End diff --
@vladimir-kotikov to help review - as far as I remember platforms never
parse the root config. In particular, the root config can have conditional
elements -
```xml
<platform name="ios">
<icon ... >
</platform>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
