HI all, i fixed CB-11078 fixed "Empty string for BackgroundColor preference crashes application" issue
* issue https://issues.apache.org/jira/browse/CB-11078 <https://issues.apache.org/jira/browse/CB-11078>* *pull request link https://github.com/apache/cordova-android/pull/316 <https://github.com/apache/cordova-android/pull/316>*All checks have passed If this is okey Can you merge this to the main branch? On Thu, Jul 14, 2016 at 5:53 AM, Jesse <purplecabb...@gmail.com> wrote: > Here is the correct link, sorry for the confusion > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=131 > > > > @purplecabbage > risingj.com > > On Wed, Jul 13, 2016 at 4:20 PM, Jesse <purplecabb...@gmail.com> wrote: > > > Oops ... the filter is private ... > > > > > > @purplecabbage > > risingj.com > > > > On Wed, Jul 13, 2016 at 4:02 PM, julio cesar sanchez < > > jcesarmob...@gmail.com> wrote: > > > >> Jesse, I get this error message > >> > >> The requested board cannot be viewed because it either does not exist or > >> you do not have permission to view it. > >> > >> 2016-07-14 0:52 GMT+02:00 Jesse <purplecabb...@gmail.com>: > >> > >> > Good work Akila! > >> > > >> > I have created a board in jira for issues that are tagged as 'easyfix' > >> > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=129 > >> > > >> > These make a good starting point for anyone looking to get their feet > >> wet. > >> > > >> > Cheers, > >> > Jesse > >> > > >> > > >> > @purplecabbage > >> > risingj.com > >> > > >> > On Wed, Jul 13, 2016 at 12:49 AM, Akila Wicky <asak...@gmail.com> > >> wrote: > >> > > >> > > Thank you Jesse for the support. > >> > > > >> > > All checks have passed. > >> > > > >> > > I was on the way of developing a new Feature to Apache Cordova. That > >> was > >> > my > >> > > intention. Bug fixing will gave me some good knowledge about the > base. > >> > Can > >> > > you suggest some more steps learn developing a New Feature to this > >> > > platform? > >> > > > >> > > > >> > > On Wed, Jul 13, 2016 at 11:38 AM, Akila Wicky <asak...@gmail.com> > >> wrote: > >> > > > >> > > > Hi sanjeewa, > >> > > > > >> > > > I'm already on it. > >> > > > > >> > > > Thank you > >> > > > > >> > > > On Wed, Jul 13, 2016 at 11:26 AM, Sanjeewa <sanjeewa...@gmail.com > > > >> > > wrote: > >> > > > > >> > > >> Hi, > >> > > >> Can i work on this bug? > >> > > >> Thanks.. > >> > > >> > >> > > >> Sent from my Sony Xperia™ smartphone > >> > > >> > >> > > >> ---- Jesse wrote ---- > >> > > >> > >> > > >> >The fact that you changed 64 files is probably a red flag, I > would > >> > > >> expect this to be a 1 or 2 line fix. > >> > > >> >I'll look more in the morning. > >> > > >> > > >> > > >> >> On Jul 12, 2016, at 10:27 PM, Akila Wicky <asak...@gmail.com> > >> > wrote: > >> > > >> >> > >> > > >> >> HI all, > >> > > >> >> > >> > > >> >> i fixed CB-11078 fixed "Empty string for BackgroundColor > >> preference > >> > > >> crashes application" issue but when i pull request it to the main > >> > > branch it > >> > > >> shows 2 failing and 1 successful checks. > >> > > >> >> > >> > > >> >> failing checks are continuous-integration/appveyor/pr and > >> > > >> >> > >> > > >> >> continuous-integration/travis-ci/push — The Travis CI build > >> failed > >> > > >> >> > >> > > >> >> https://github.com/apache/cordova-android/pull/315 > >> > > >> >> > >> > > >> >> Can i have some solution for this. > >> > > >> >> > >> > > >> >>> On Tue, Jul 12, 2016 at 11:08 AM, Akila Wicky < > >> asak...@gmail.com> > >> > > >> wrote: > >> > > >> >>> Hi > >> > > >> >>> > >> > > >> >>> Thank you Jesse, I accidently missed the dev list from the > >> mail.. > >> > > >> >>> I'll go through with this.. > >> > > >> >>> > >> > > >> >>>> On Tue, Jul 12, 2016 at 10:45 AM, Jesse < > >> purplecabb...@gmail.com > >> > > > >> > > >> wrote: > >> > > >> >>>> Just realized the Dev list was dropped from the last email, > >> so I > >> > am > >> > > >> reposting so others might also benefit. > >> > > >> >>>> > >> > > >> >>>> === > >> > > >> >>>> > >> > > >> >>>> Create a new cordova app , add android, and recreate the > >> issue. > >> > > >> >>>> Once you have done that, you can open the project at > >> > > >> /platforms/android in android studio and debug the error. > >> > > >> >>>> Fix it in place, and when you are satisfied copy your > changes > >> > back > >> > > >> to you android fork. > >> > > >> >>>> Verify with your repro app and android fork by doing a : > >> > > >> >>>> Cordova platform rm android > >> > > >> >>>> Cordova platform add path-to-android-fork > >> > > >> >>>> Cordova run android > >> > > >> >>>> > >> > > >> >>>> Be sure you have copied all your changes back to your fork > >> before > >> > > >> you do the platform rm !!! > >> > > >> >>>> > >> > > >> >>>> Bonus points: add a test to prove the issue is fixed, and > >> doesn't > >> > > >> resurface. > >> > > >> >>>> > >> > > >> >>>>> On Jul 11, 2016, at 9:51 PM, Akila Wicky < > asak...@gmail.com> > >> > > wrote: > >> > > >> >>>>> > >> > > >> >>>>> Jesse, > >> > > >> >>>>> > >> > > >> >>>>> Hi, Thanks for you help in finding a bug. Can you give me > >> some > >> > way > >> > > >> to work in this bug? > >> > > >> >>>>> > >> > > >> >>>>> I forked and cloned android-cordova and build it from the > >> > sources. > >> > > >> And also i imported this project to Android Studio. Can you give > me > >> > some > >> > > >> idea to approach to this bug fix. > >> > > >> >>>> > >> > > >> >>>> > >> > > >> >>>>> On Jul 7, 2016, at 1:32 PM, Akila Wicky <asak...@gmail.com > > > >> > > wrote: > >> > > >> >>>>> > >> > > >> >>>>> Hi, > >> > > >> >>>>> > >> > > >> >>>>> > >> > > >> >>>>> Thanks, I’m working on it > >> > > >> >>>>> > >> > > >> >>>>>> On Fri, Jul 8, 2016 at 1:48 AM, Jesse < > >> purplecabb...@gmail.com > >> > > > >> > > >> wrote: > >> > > >> >>>>>> Here's a good one. > >> > > >> >>>>>> https://issues.apache.org/jira/browse/CB-11078 > >> > > >> >>>>>> > >> > > >> >>>>>> > >> > > >> >>>>>> > >> > > >> >>>>>> @purplecabbage > >> > > >> >>>>>> risingj.com > >> > > >> >>>>>> > >> > > >> >>>>>>> On Thu, Jul 7, 2016 at 11:54 AM, Akila Wicky < > >> > asak...@gmail.com > >> > > > > >> > > >> wrote: > >> > > >> >>>>>>> Thanks, > >> > > >> >>>>>>> > >> > > >> >>>>>>> I'm comfortable with Android.So it would be great if i > can > >> > find > >> > > a > >> > > >> stater issue with Android. > >> > > >> >>>>>>> > >> > > >> >>>>>>>> On Thu, Jul 7, 2016 at 9:59 PM, Jesse < > >> > purplecabb...@gmail.com > >> > > > > >> > > >> wrote: > >> > > >> >>>>>>>> Thanks, and Welcome Akila! > >> > > >> >>>>>>>> > >> > > >> >>>>>>>> What platforms are you most comfortable with? Android, > >> Java, > >> > > >> iOS, Obj-C, Windows, C#, js, ... > >> > > >> >>>>>>>> > >> > > >> >>>>>>>> One person's starter fix can be another person's > blocker. > >> > > >> >>>>>>>> > >> > > >> >>>>>>>> Cheers, > >> > > >> >>>>>>>> Jesse > >> > > >> >>>>>>>> > >> > > >> >>>>>>>> > On Jul 6, 2016, at 10:08 PM, Akila Wicky < > >> > asak...@gmail.com> > >> > > >> wrote: > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > Hi everyone, I'm still a beginner to this community. > So > >> it > >> > > >> would be great > >> > > >> >>>>>>>> > if i can find a stater issue to fix as a beginning. > Can > >> you > >> > > >> help me with > >> > > >> >>>>>>>> > this? Hope i can start a good journey with this > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > -- > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > *Thanks and Regards,*Akila Wickramarachchi > >> > > >> >>>>>>>> > > >> > > >> >>>>>>>> > Undergraduate at University Of Peradeniya > >> > > >> >>>>>>>> > < > >> > > >> > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-headline > >> > > >> > > >> > > >> >>>>>>>> > Email : asak...@gmail.com > >> > > >> >>>>>>>> > Linkedin : Akila Wickramarachchi > >> > > >> >>>>>>>> > < > >> > > >> > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-name > >> > > >> > > >> > > >> >>>>>>>> > Blog : http://akilacollection.blogspot.com/ > >> > > >> >>>>>>>> > Github : https://github.com/akilawickey > >> > > >> >>>>>>> > >> > > >> >>>>>>> > >> > > >> >>>>>>> > >> > > >> >>>>>>> -- > >> > > >> >>>>>>> Thanks and Regards, > >> > > >> >>>>>>> > >> > > >> >>>>>>> Akila Wickramarachchi > >> > > >> >>>>>>> > >> > > >> >>>>>>> Undergraduate at University Of Peradeniya > >> > > >> >>>>>>> Email : asak...@gmail.com > >> > > >> >>>>>>> Linkedin : Akila Wickramarachchi > >> > > >> >>>>>>> Blog : http://akilacollection.blogspot.com/ > >> > > >> >>>>>>> Github : https://github.com/akilawickey > >> > > >> >>>>> > >> > > >> >>>>> > >> > > >> >>>>> > >> > > >> >>>>> -- > >> > > >> >>>>> Thanks and Regards, > >> > > >> >>>>> > >> > > >> >>>>> Akila Wickramarachchi > >> > > >> >>>>> > >> > > >> >>>>> Undergraduate at University Of Peradeniya > >> > > >> >>>>> Email : asak...@gmail.com > >> > > >> >>>>> Linkedin : Akila Wickramarachchi > >> > > >> >>>>> Blog : http://akilacollection.blogspot.com/ > >> > > >> >>>>> Github : https://github.com/akilawickey > >> > > >> >>> > >> > > >> >>> > >> > > >> >>> > >> > > >> >>> -- > >> > > >> >>> Thanks and Regards, > >> > > >> >>> > >> > > >> >>> Akila Wickramarachchi > >> > > >> >>> > >> > > >> >>> Undergraduate at University Of Peradeniya > >> > > >> >>> Email : asak...@gmail.com > >> > > >> >>> Linkedin : Akila Wickramarachchi > >> > > >> >>> Blog : http://akilacollection.blogspot.com/ > >> > > >> >>> Github : https://github.com/akilawickey > >> > > >> >> > >> > > >> >> > >> > > >> >> > >> > > >> >> -- > >> > > >> >> Thanks and Regards, > >> > > >> >> > >> > > >> >> Akila Wickramarachchi > >> > > >> >> > >> > > >> >> Undergraduate at University Of Peradeniya > >> > > >> >> Email : asak...@gmail.com > >> > > >> >> Linkedin : Akila Wickramarachchi > >> > > >> >> Blog : http://akilacollection.blogspot.com/ > >> > > >> >> Github : https://github.com/akilawickey > >> > > >> > >> > > > > >> > > > > >> > > > > >> > > > -- > >> > > > > >> > > > > >> > > > *Thanks and Regards,*Akila Wickramarachchi > >> > > > > >> > > > Undergraduate at University Of Peradeniya > >> > > > < > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-headline > >> > > > > >> > > > Email : asak...@gmail.com > >> > > > Linkedin : Akila Wickramarachchi > >> > > > < > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-name > >> > > > > >> > > > Blog : http://akilacollection.blogspot.com/ > >> > > > Github : https://github.com/akilawickey > >> > > > > >> > > > >> > > > >> > > > >> > > -- > >> > > > >> > > > >> > > *Thanks and Regards,*Akila Wickramarachchi > >> > > > >> > > Undergraduate at University Of Peradeniya > >> > > < > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-headline > >> > > > > >> > > Email : asak...@gmail.com > >> > > Linkedin : Akila Wickramarachchi > >> > > < > >> > > > >> > > >> > https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-name > >> > > > > >> > > Blog : http://akilacollection.blogspot.com/ > >> > > Github : https://github.com/akilawickey > >> > > > >> > > >> > > > > > -- *Thanks and Regards,*Akila Wickramarachchi Undergraduate at University Of Peradeniya <https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-headline> Email : asak...@gmail.com Linkedin : Akila Wickramarachchi <https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-name> Blog : http://akilacollection.blogspot.com/ Github : https://github.com/akilawickey
