Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/185#discussion_r73113256
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -105,7 +105,7 @@ var handlers = {
var type = obj.type;
if(type === 'projectReference') {
- project.removeProjectReference(path.join(plugin.dir, src),
getTargetConditions(obj));
+ project.removeProjectReference(path.join('..', '..',
'plugins', plugin.id, src), getTargetConditions(obj));
--- End diff --
Updated, thanks for review!
There was an issue with mock dummyplugin, which PluginInfo.dir was
initialized with a corresponding fixture path - so in case when the temp folder
was on a different drive it caused path.relative to resolve in an absolute path
in
[PluginHandler.framework.install](https://github.com/daserge/cordova-windows/blob/2bc5d96bdd0f6c9328680bede1b535dde218e23c/template/cordova/lib/PluginHandler.js#L91).
Normally we have a plugin.dir path initialized with relative path to the
project root, i.e. `project_root/plugins/plugin-id` - so I've updated the tests
accordingly.
I've also tested that install/rm a plugin from another drive updates jsproj
files properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
