It was on a branch I was working on, and the bug was that doing an async
file check that needed to be synchronous.  I fixed that on the pull request
I was working on and it all appears to work now.  I have to clean up the PR
and re-submit the thing, because the PR got all screwed up.

On Thu, Aug 11, 2016 at 7:13 AM, Alexander Sorokin (Akvelon) <
v-als...@microsoft.com> wrote:

> Hey guys.
>
> This test was written by me. It looks like the error is happening here:
> https://github.com/apache/cordova-android/blob/master/
> spec/e2e/plugin.spec.js#L38
>
> Surprisingly I cannot reproduce the failure neither on my Windows machine
> nor on my Mac.
>
> Regarding the questions,
> 1. See the link above
> 2. fakeLib is just a dummy dependency so if it is required for plugins to
> have a build.gradle file then we should definitely put one there
> 3. We should definitely change the dummy plugin to be valid cordova plugin.
>
> I could make the change but I'm not sure how to fix this because I have no
> repro. Will adding an empty build.gradle file to the fakeLib do?
>
> Thanks,
> Alexander Sorokin
>
> -----Original Message-----
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Thursday, August 11, 2016 1:23 AM
> To: dev@cordova.apache.org
> Subject: Re: [Android] What is Cordova Plugin Fake, and why is it missing
> a gradle file?
>
> This was not caught by CI because the e2e tests (under script 'test-build)
> is not part of `npm test`.
>
> My guess is the file was inadvertently not checked in to git thus the test
> failure.
>
> On Wed, Aug 10, 2016 at 11:39 AM, Joe Bowser <bows...@gmail.com> wrote:
>
> > Hey
> >
> > I just noticed that travis broke on this test that someone wrote for
> > plugin installation, and I have a few questions about it.
> >
> > 1. Where is the repo for this test?
> > 2. What is fakeLib, and why doesn't fakeLib have a gradle file copied
> > over (all plugins are required to have if if it doesn't exist) 3. Do
> > we have to change the test for this?
> >
> > If I could get more information on this CI test, that would definitely
> > be helpful
> >
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2ftravi
> > s-ci.org%2fapache%2fcordova-android%2fbuilds%2f150161649&
> data=02%7c01%7cv-alsoro%40microsoft.com%7c1e71fbcbf3644ed7118508d3c16d
> 0c71%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%
> 7c636064646510103910&sdata=2pRQzbIECLjIfIe%2ffpTGnHbh4tURM%
> 2f7mhbRZT10ybSk%3d
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

Reply via email to