I think we should add an overload and add back the old API method, since this is effectively removing API and we don't want the hassle of a major version bump.
On Friday, August 26, 2016, <alsoro...@apache.org> wrote: > Repository: cordova-plugin-media > Updated Branches: > refs/heads/master 910d3c798 -> 42b279b91 > > > CB-11380 (ios) Updated modified method signature in the .h file > > > Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-media/repo > Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin- > media/commit/42b279b9 > Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin- > media/tree/42b279b9 > Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin- > media/diff/42b279b9 > > Branch: refs/heads/master > Commit: 42b279b911c4b20689290f55ecb849905d3f1673 > Parents: 910d3c7 > Author: Alexander Sorokin <alexander.soro...@akvelon.com <javascript:;>> > Authored: Fri Aug 26 17:06:07 2016 +0300 > Committer: Alexander Sorokin <alexander.soro...@akvelon.com <javascript:;> > > > Committed: Fri Aug 26 17:06:07 2016 +0300 > > ---------------------------------------------------------------------- > src/ios/CDVSound.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/cordova-plugin- > media/blob/42b279b9/src/ios/CDVSound.h > ---------------------------------------------------------------------- > diff --git a/src/ios/CDVSound.h b/src/ios/CDVSound.h > index 1dca574..c3f7a6c 100644 > --- a/src/ios/CDVSound.h > +++ b/src/ios/CDVSound.h > @@ -106,7 +106,7 @@ typedef NSUInteger CDVMediaMsg; > - (NSURL*)urlForRecording:(NSString*)resourcePath; > - (NSURL*)urlForPlaying:(NSString*)resourcePath; > > -- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath > withId:(NSString*)mediaId doValidation:(BOOL)bValidate > forRecording:(BOOL)bRecord; > +- (CDVAudioFile*)audioFileForResource:(NSString*)resourcePath > withId:(NSString*)mediaId doValidation:(BOOL)bValidate > forRecording:(BOOL)bRecord suppressValidationErrors:(BOOL)bSuppress; > - (BOOL)prepareToPlay:(CDVAudioFile*)audioFile withId:(NSString*)mediaId; > - (NSString*)createMediaErrorWithCode:(CDVMediaError)code > message:(NSString*)message; > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org > <javascript:;> > For additional commands, e-mail: commits-h...@cordova.apache.org > <javascript:;> > >
