Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/195#discussion_r79803408
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -390,11 +390,6 @@ AppxManifest.prototype.getVisualElements = function ()
{
},
setForegroundText: function (color) {
if (color) {
--- End diff --
Instead of `if (color) { visualElements.attrib.ForegroundText = color; }`
would it be better to use `visualElements.attrib.ForegroundText = color ||
'light'` so that ForegroundText would be reset as default `light` if we set
`dark` via preference for example and then remove the preference from
config.xml entirely?
Advertising
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
