Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/139#discussion_r80812614
--- Diff: src/platform-release.js ---
@@ -128,14 +127,32 @@ exports.prepareReleaseBranchCommand = function*() {
'\n' +
'Usage: $0 prepare-release-branch --version=3.6.0 -r
platform')
);
+
var repos = flagutil.computeReposFromFlag(argv.r);
- var version = flagutil.validateVersionString(argv.version);
- var branchName = getVersionBranchName(version);
+ var branchName = null;
+
// First - perform precondition checks.
yield repoupdate.updateRepos(repos, [], true);
yield repoutil.forEachRepo(repos, function*(repo) {
+
+ var version = null;
+
+ if (argv.version === undefined) {
+ // Grabbing version from platformPackageJson
--- End diff --
minor: can you fix the indenting? the else should be in the same vertical
line as the if. comment should be inline with the vars, etc.
once you fix it, do a `git add platform-release.js` and then `git commit
--amend`. This will allow you to add the change to the existing commit instead
of creating a new commit. You will then have to push it with `git push audrey
master --force`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
