Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/207#discussion_r87807973 --- Diff: template/cordova/lib/PluginInfo.js --- @@ -0,0 +1,150 @@ +var semver = require('semver'); +var CommonPluginInfo = require('cordova-common').PluginInfo; + +var MANIFESTS = { + 'windows': { + '8.1.0': 'package.windows.appxmanifest', + '10.0.0': 'package.windows10.appxmanifest' + }, + 'phone': { + '8.1.0': 'package.phone.appxmanifest', + '10.0.0': 'package.windows10.appxmanifest' + }, + 'all': { + '8.1.0': ['package.windows.appxmanifest', 'package.phone.appxmanifest'], + '10.0.0': 'package.windows10.appxmanifest' + } +}; + +var SUBSTS = ['package.phone.appxmanifest', 'package.windows.appxmanifest', 'package.windows10.appxmanifest']; +var TARGETS = ['windows', 'phone', 'all']; +/* +A class for holidng the information currently stored in plugin.xml +It's inherited from cordova-common's PluginInfo class +In addition it overrides getConfigFiles method to use windows-specific logic + */ +function PluginInfo(dirname) { + // We needn't use 'util.inherit' in this case because there aren't any methods on prototype in cordova-common's PluginInfo class + CommonPluginInfo.apply(this, arguments); + var parentGetConfigFiles = this.getConfigFiles; + var parentGetEditConfigs = this.getEditConfigs; + + this.getEditConfigs = function(platform) { + var editConfigs = parentGetEditConfigs(platform); + return processChanges(editConfigs); + }; + + this.getConfigFiles = function(platform) { + var configFiles = parentGetConfigFiles(platform); + return processChanges(configFiles); + }; + + function processChanges(changes) { --- End diff -- I'd suggest to move this out of `PluginInfo` - this way it'd be possible to use this function in tests (using `rewire`)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org